Date: Tue, 20 Jan 2015 01:40:31 -0700 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "marino@freebsd.org" <marino@freebsd.org>, Adam Weinberger <adamw@FreeBSD.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r377495 - head/textproc/py-pygments Message-ID: <7FE7D759-28BD-4A85-AE0D-83B163FDC7FB@adamw.org> In-Reply-To: <20150120082846.GA84520@FreeBSD.org> References: <201501200412.t0K4CVOj052563@svn.freebsd.org> <20150120081220.GB57237@FreeBSD.org> <54BE0F14.5030304@marino.st> <20150120082846.GA84520@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 20, 2015, at 01:28, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >=20 >> On Tue, Jan 20, 2015 at 09:17:24AM +0100, John Marino wrote: >>> On 1/20/2015 09:12, Alexey Dokuchaev wrote: >>>> On Tue, Jan 20, 2015 at 04:12:31AM +0000, Adam Weinberger wrote: >>>> New Revision: 377495 >>>> URL: https://svnweb.freebsd.org/changeset/ports/377495 >>>> QAT: https://qat.redports.org/buildarchive/r377495/ >>>>=20 >>>> Log: >>>> Update to 2.0.1. >>>>=20 >>>> [...] >>>> -OPTIONS_DEFINE=3D DOCS >>>> - >>>=20 >>> Commit log does not mention this change, was it intended? If so, what >>> was the reason behind it? >>=20 >> The line is redundant -- it's presence or absence doesn't change >> anything. >=20 > In this case it would be nice to mention something like "remove DOCS optio= n > because the port no longer installs documentation" in the log. >=20 >> You know how I write commit messages and thus know I agree it >> could have been mentioned given how short the message was (if it were 1 >> of 100 changes I wouldn't have mentioned it myself). >=20 > Yes, I know. >=20 > ./danfe >=20 Yes, you're both correct. I'm not usually a terse commit message person, and= it was doubly bad given that I was doing the commit without nivit's approva= l.=20 # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7FE7D759-28BD-4A85-AE0D-83B163FDC7FB>