Date: Wed, 24 Mar 2010 10:07:22 -0400 From: John Baldwin <jhb@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205541 - head/sys/compat/linprocfs Message-ID: <201003241007.22189.jhb@freebsd.org> In-Reply-To: <20100323215554.GH2415@deviant.kiev.zoral.com.ua> References: <201003232149.o2NLnYfs097218@svn.freebsd.org> <20100323215554.GH2415@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 23 March 2010 5:55:54 pm Kostik Belousov wrote: > On Tue, Mar 23, 2010 at 09:49:34PM +0000, John Baldwin wrote: > > Author: jhb > > Date: Tue Mar 23 21:49:33 2010 > > New Revision: 205541 > > URL: http://svn.freebsd.org/changeset/base/205541 > > > > Log: > > Implement /proc/filesystems. > > > > Submitted by: Fernando Apesteguia fernando.apesteguia (gmail) > > > > Modified: > > head/sys/compat/linprocfs/linprocfs.c > > > > Modified: head/sys/compat/linprocfs/linprocfs.c > > ============================================================================== > > --- head/sys/compat/linprocfs/linprocfs.c Tue Mar 23 21:43:01 2010 (r205540) > > +++ head/sys/compat/linprocfs/linprocfs.c Tue Mar 23 21:49:33 2010 (r205541) > > @@ -1227,6 +1227,22 @@ linprocfs_docmdline(PFS_FILL_ARGS) > > return (0); > > } > > > > +/* > > + * Filler function for proc/filesystems > > + */ > > +static int > > +linprocfs_dofilesystems(PFS_FILL_ARGS) > > +{ > > + struct vfsconf *vfsp; > > + > > + TAILQ_FOREACH(vfsp, &vfsconf, vfc_list) { > > + if (vfsp->vfc_flags & VFCF_SYNTHETIC) > > + sbuf_printf(sb, "nodev"); > > + sbuf_printf(sb, "\t%s\n", vfsp->vfc_name); > > + } > > + return(0); > > +} > I think the list iteration should be protected by Giant. > Am I mistaken ? Oh, yeah, that is true. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003241007.22189.jhb>