Date: Wed, 13 Oct 2010 15:20:24 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r213744 - head/bin/sh Message-ID: <20101013222024.GA17164@dragon.NUXI.org> In-Reply-To: <20101013152037.S2102@besplex.bde.org> References: <201010121924.o9CJOgwn059485@svn.freebsd.org> <20101013133713.L1075@besplex.bde.org> <20101013040543.GB13694@dragon.NUXI.org> <20101013152037.S2102@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 13, 2010 at 03:29:27PM +1100, Bruce Evans wrote: > Add __noinline or whatever attributes to STATIC (but keep static in > it) for the DEBUG >= 3 case if you are going that far. __noinline > should be a syntax error for variables, so this should also find any > STATICs still on variables. The spelling fix of changing STATIC to > what it actually means > (ASSORTED_HACKS_FOR_DEBUGGING_BUT_NOW_ONLY_FOR_FUNCTIONS) goes too far > for me. I've make all uses "static". Otherwise we have some of the functions and variable "STATIC" (if from 4.4BSD), and some others "static" (added later by FreeBSD). Surely this inconsistency isn't desired. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101013222024.GA17164>