Date: Wed, 24 Aug 2005 21:49:45 +0900 From: "R. Imura" <imura@ryu16.org> To: Rudolf Cejka <cejkar@fit.vutbr.cz> Cc: current@freebsd.org Subject: Re: kiconv related enhancement Message-ID: <20050824124945.GB62229%imura@ryu16.org> In-Reply-To: <20050823143456.GA79107@fit.vutbr.cz> References: <20050821092816.GA51886%imura@ryu16.org> <20050823143456.GA79107@fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Tue, Aug 23, 2005 at 04:34:56PM +0200, Rudolf Cejka wrote: > Please, do you have a plan to fix ranges too? You have either allocate > sufficient space (ICONV_CSNMAXLEN + 1 instead of just ICONV_CSNMAXLEN), > or check for string length >= ICONV_CSNMAXLEN instead of > ICONV_CSNMAXLEN. > The second problem is that some strcpy()s could overwrite one byte > after allocated space and strnpcy()s could produce unterminated > strings - everything is around egrep -r "ICONV_C(S|NV)NMAXLEN" /usr/src. > The last problem is that sys/libkern/iconv.c does not check the length > of from and to in iconv_sysctl_add(), which can be source of unexpected > results. Thanks. Fixed. I remember that this is the second time you ask me about the issue. I apologize that I'm late, and thank you for testing new patches. Redards, - R. Imura
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050824124945.GB62229%imura>