Date: Sat, 22 Jul 2006 11:51:50 GMT From: Paolo Pisati <piso@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 102136 for review Message-ID: <200607221151.k6MBpoLS030085@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=102136 Change 102136 by piso@piso_longino on 2006/07/22 11:51:17 use IF_FAST macro instead of checking for INTR_FAST in flags, and place a comment about bus-related data struct that don't record the filter function. Affected files ... .. //depot/projects/soc2006/intr_filter/dev/pccbb/pccbb.c#3 edit .. //depot/projects/soc2006/intr_filter/dev/pccbb/pccbbvar.h#3 edit Differences ... ==== //depot/projects/soc2006/intr_filter/dev/pccbb/pccbb.c#3 (text+ko) ==== @@ -361,7 +361,7 @@ * least common denominator until the base system supports mixing * and matching better. */ - if ((flags & INTR_FAST) != 0) + if (IS_FAST(filter, intr)) return (EINVAL); ih = malloc(sizeof(struct cbb_intrhand), M_DEVBUF, M_NOWAIT); if (ih == NULL) ==== //depot/projects/soc2006/intr_filter/dev/pccbb/pccbbvar.h#3 (text+ko) ==== @@ -31,7 +31,14 @@ * Structure definitions for the Cardbus Bridge driver */ +/* + * XXX this structure and all the code that manipulates + * it don't support interrupt filter model. + */ struct cbb_intrhand { +#if 0 + driver_filter_t *filter; +#endif driver_intr_t *intr; void *arg; struct cbb_softc *sc;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607221151.k6MBpoLS030085>