Date: Fri, 18 Sep 1998 13:36:56 -0500 From: Alex Nash <nash@mcs.net> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: Eivind Eklund <eivind@yes.no>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.c src/sys/conf files src/sys/i386/isa if_ed.c if_ep.c if_lnc.c src/sys/net if_ethersubr.c src Message-ID: <19980918133656.A6449@Mcs.Net> In-Reply-To: <199809181132.NAA26299@labinfo.iet.unipi.it>; from Luigi Rizzo on Fri, Sep 18, 1998 at 01:32:03PM %2B0200 References: <19980918133152.09027@follo.net> <199809181132.NAA26299@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 18, 1998 at 01:32:03PM +0200, Luigi Rizzo wrote: > i have asked permission to Jordan and Garret on these specific issues. > > About the ipfw binary compatibility my apologies because i forgot > to mention that explicitly to the reviewers (and yes, now i remember > you pointed that out), but the change it was absolutely necessary > to have dummynet working. > > In my partial defense: > > * the change only affects one binary, ipfw, and there is no user > interface change (i.e. you still have 10 ports available in a rule) Changing FW_IFNLEN to an arbitrary value was a step backwards. We were already bitten by this once, and that's why it was set to IFNAMSIZ. If you want to argue that 16 character interface names will never exist, change IFNAMSIZ. Interface name length constraints don't belong in ipfw. Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980918133656.A6449>