Date: Thu, 30 May 2013 09:57:15 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: freebsd-bugs@freebsd.org, freebsd-net@freebsd.org Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion Message-ID: <20130530075715.GA64174@onelab2.iet.unipi.it> In-Reply-To: <201305300743.r4U7hlE3088879@freefall.freebsd.org> References: <201305300743.r4U7hlE3088879@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 30, 2013 at 07:43:47AM +0000, linimon@freebsd.org wrote: > Old Synopsis: Invalid index calucation in netmap macro expansion > New Synopsis: [netmap] [patch] Invalid index calucation in netmap macro expansion > > Responsible-Changed-From-To: freebsd-bugs->freebsd-net > Responsible-Changed-By: linimon > Responsible-Changed-When: Thu May 30 07:43:27 UTC 2013 > Responsible-Changed-Why: > Over to maintainer(s). Thanks for the report. The macro is correct as implemented. The problem, in case, is in the description in netmap_user.h which is confusing and should be improved as follows: -* char *buf = NETMAP_BUF(ring, index) returns a pointer to -* the i-th buffer +* char *buf = NETMAP_BUF(ring, x) returns a pointer to +* the buffer numbered 'x' This will be committed soon, so please close the PR cheers luigi > http://www.freebsd.org/cgi/query-pr.cgi?pr=179083 > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130530075715.GA64174>