Date: Sat, 18 Sep 2010 13:23:41 +0200 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212804 - head/sys/boot/zfs Message-ID: <20100918112341.GA1733@mole.fafoe.narf.at> In-Reply-To: <201009172251.o8HMpjZJ044307@svn.freebsd.org> References: <201009172251.o8HMpjZJ044307@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Um, was the change from 32 to 31 deliberate? On Fri, Sep 17, 2010 at 10:51:45PM +0000, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Fri Sep 17 22:51:45 2010 > New Revision: 212804 > URL: http://svn.freebsd.org/changeset/base/212804 > > Log: > Remove magic value. > > Modified: > head/sys/boot/zfs/zfs.c > > Modified: head/sys/boot/zfs/zfs.c > ============================================================================== > --- head/sys/boot/zfs/zfs.c Fri Sep 17 22:05:27 2010 (r212803) > +++ head/sys/boot/zfs/zfs.c Fri Sep 17 22:51:45 2010 (r212804) > @@ -45,6 +45,8 @@ __FBSDID("$FreeBSD$"); > > #include "zfsimpl.c" > > +#define MAXBDDEV 31 > + > static int zfs_open(const char *path, struct open_file *f); > static int zfs_write(struct open_file *f, void *buf, size_t size, size_t *resid); > static int zfs_close(struct open_file *f); > @@ -402,7 +404,7 @@ zfs_dev_init(void) > * diskN, diskNpM or diskNsM. > */ > zfs_init(); > - for (unit = 0; unit < 32 /* XXX */; unit++) { > + for (unit = 0; unit < MAXBDDEV; unit++) { > sprintf(devname, "disk%d:", unit); > fd = open(devname, O_RDONLY); > if (fd == -1) >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100918112341.GA1733>