Date: Sat, 15 Jun 2013 12:16:33 GMT From: John Marino <draco@marino.st> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/179571: [PATCH] devel/gccmakedep: improve gcpp test (764 dports broke) Message-ID: <201306151216.r5FCGX1j059718@oldred.freebsd.org> Resent-Message-ID: <201306151220.r5FCK0ug065713@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 179571
>Category: ports
>Synopsis: [PATCH] devel/gccmakedep: improve gcpp test (764 dports broke)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jun 15 12:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: John Marino
>Release:
>Organization:
>Environment:
>Description:
During the last change to gccmakedep, a configuration item based on a test for gcpp based on $OSVERSION was added.
Since it's trivial to actually test for the presence of gcpp, this should be used instead of $OSVERSION checks.
Not only is it a better test, but it's also non-platform specific. 764 Dragonfly dports broke because of the new gcpp test.
Please change the test per applied patch -- it should be transparent for FreeBSD.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- Makefile.orig 2013-06-15 12:01:35.215015000 +0000
+++ Makefile
@@ -17,8 +17,7 @@ PLIST_FILES= bin/gccmakedep
.include <bsd.port.pre.mk>
# Attempt to force use of GNU cpp, if it is installed as /usr/bin/gcpp.
-.if (${OSVERSION} >= 900506 && ${OSVERSION} < 1000000) || \
- ${OSVERSION} >= 1000010
+.if exists(/usr/bin/gcpp)
CONFIGURE_ENV+= ac_cv_path_RAWCPP="gcpp"
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306151216.r5FCGX1j059718>