Date: Sat, 20 Sep 2014 14:00:29 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193793] New: ports-mgmt/portlint: split 192633 - improve COMMENTS validation Message-ID: <bug-193793-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193793 Bug ID: 193793 Summary: ports-mgmt/portlint: split 192633 - improve COMMENTS validation Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) I frequently run into ports with "files" in the COMMENT definition. There's nothing wrong with that. However, portlint trips on it, e.g. WARN: Makefile: possible direct use of "files" "COMMENT= List, test, and extract compressed files in a ZIP archive" found. if so, use ${FILESDIR} instead. Please make the "files" check smarter to not trip if it's part of a COMMENT. (see archivers/unzip for example) Speaking of COMMENT, it's not supposed to start with "A ", "An ", or "The ", but portlint doesn't check for this. It seems like an easy rule to implement. It's also not supposed to start with the name of the port, but I have no idea if this rule is implemented or not. e.g. math/fractals COMMENT= Fractals is an awesome snowflake generator program Portlint could flag that. (does it already?) --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer marcus@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193793-13>