Date: Sat, 15 Jun 2013 21:07:41 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/179599: [patch] Fix build for devel/cgit on systems with WITHOUT_NLS Message-ID: <201306152107.r5FL7fiU047892@oldred.freebsd.org> Resent-Message-ID: <201306152110.r5FLA1gc023241@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 179599
>Category: ports
>Synopsis: [patch] Fix build for devel/cgit on systems with WITHOUT_NLS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jun 15 21:10:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Kevin Zheng
>Release: 9.1-RELEASE-p3
>Organization:
>Environment:
FreeBSD sigma.local 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:11:52 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
I'm one of those few people who set WITHOUT_NLS (or its modern equivalent) because I simply never use NLS anyways. Unfortunately this means that I run in to a lot of problems with ports that want gettext around anyways.
When "WITHOUT_NLS=yes" is set in 'make.conf', gettext is not installed in my Poudriere cleanroom build. On normal systems, gettext is usually there, and on Redports, NLS is always built. Hence, this issue isn't usually reported until some poor guy like me comes along.
Basically, I can fix the build for me by adding "USES+= gettext" in the port Makefile. Because I am greedy and selfish, I'll do this until I can find a better fix that doesn't require us use something we don't want.
Also, take maintainership because I use this port.
>How-To-Repeat:
Set up a poudriere with "WITHOUT_NLS=yes" set and build cgit. It won't build.
>Fix:
Apply the attached patch.
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 321016)
+++ Makefile (working copy)
@@ -10,8 +10,8 @@
DISTFILES= cgit-${PORTVERSION}${EXTRACT_SUFX}:cgit \
git-${GIT_VERSION}.tar.gz:git
-MAINTAINER= ports@FreeBSD.org
-COMMENT= Fast webinterface for git
+MAINTAINER= kevinz5000@gmail.com
+COMMENT= Fast web frontend for Git repositories
LICENSE= GPLv2
@@ -19,7 +19,7 @@
GIT_VERSION= 1.8.2.3
USE_BZIP2= yes
USE_GMAKE= yes
-USES= iconv shebangfix
+USES= gettext iconv shebangfix
SHEBANG_FILES= filters/html-converters/resources/markdown.pl
USE_GMAKE= yes
USE_OPENSSL= yes
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306152107.r5FL7fiU047892>