Date: Thu, 9 Jul 2015 19:20:47 +0200 From: John Marino <freebsd.contact@marino.st> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391626 - head/games/warzone2100 Message-ID: <559EAD6F.3050409@marino.st> In-Reply-To: <20150709171246.GB46547@hades.panopticon> References: <201507090944.t699iqBR039850@repo.freebsd.org> <559E431B.6030708@marino.st> <20150709171246.GB46547@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/9/2015 7:12 PM, Dmitry Marakasov wrote: > * John Marino (freebsd.contact@marino.st) wrote: > >>> Author: amdmi3 >>> Date: Thu Jul 9 09:44:51 2015 >>> New Revision: 391626 >>> URL: https://svnweb.freebsd.org/changeset/ports/391626 >>> >>> Log: >>> - Remove unncecessary full path to binary from *_DEPENDS >>> >>> Modified: >>> head/games/warzone2100/Makefile >>> >>> Modified: head/games/warzone2100/Makefile >>> ============================================================================== >>> --- head/games/warzone2100/Makefile Thu Jul 9 09:44:33 2015 (r391625) >>> +++ head/games/warzone2100/Makefile Thu Jul 9 09:44:51 2015 (r391626) >>> @@ -13,7 +13,7 @@ LICENSE_FILE= ${WRKSRC}/COPYING >>> >>> BUILD_DEPENDS= zip:${PORTSDIR}/archivers/zip \ >>> unzip:${PORTSDIR}/archivers/unzip \ >>> - ${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex >>> + flex:${PORTSDIR}/textproc/flex >>> LIB_DEPENDS= libphysfs.so:${PORTSDIR}/devel/physfs \ >>> libpng.so:${PORTSDIR}/graphics/png \ >>> libvorbis.so:${PORTSDIR}/audio/libvorbis \ >>> >> >> This could be a mistake. >> This changes depends from /usr/local/bin/flex to /usr/bin/flex. >> Are you sure that's what you want to do? > > As I understand, that's why binary names are preferred: as there's > /usr/bin/flex, unneeded dependency won't be installed. However, that > seem to be an artifact from 6.x days, and this dependency is not needed > at all, all supported FreeBSD releases have flex in base system. > My understanding is that you created a dependency specification that is only accidently satisfied. You asked textproc/flex to be installed, but then check /usr/bin/flex from that package (which is not inside). Flex is notorious. If flex is specified in BUILD_DEPENDS, then 100% of the time, you really, really want /usr/local/bin/flex. If /usr/bin/flex works, then you would not put it in BUILD_DEPENDS. /usr/bin/flex is available on all releases so if it works as you say, then textproc/flex will never get pulled in. My guess is that if textproc/flex is listed here, then it's needed over the base flex. Thus, I think the change is an error. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559EAD6F.3050409>