Date: Wed, 21 Jun 1995 15:50:01 -0700 From: tom@haven.uniserve.com To: freebsd-bugs Subject: bin/539: Message-ID: <199506212250.PAA11654@freefall.cdrom.com> In-Reply-To: Your message of Wed, 21 Jun 1995 15:49:29 %2B0100 <95Jun21.154940%2B0100_pdt.30740%2B2018@haven.uniserve.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>Number: 539
>Category: bin
>Synopsis:
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs (FreeBSD bugs mailing list)
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 21 15:50:00 1995
>Originator: Tom Samplonius
>Organization:
UNIServe
>Release: FreeBSD 2.0.5-RELEASE
>Environment:
>Description:
finger scans every home direcotry for .nofinger rather than checking
home directories of the users that actually match.
>How-To-Repeat:
Use finger with large number of users
>Fix:
Only check home directories if they match. The following patch
moves the hide() call just after the match() call so that only home directories
of matched users get checked.
*** finger.c.old Wed Jun 21 14:19:50 1995
--- finger.c Wed Jun 21 14:29:14 1995
***************
*** 261,270 ****
"finger: %s: no such user\n", *p);
else {
while (pw = getpwent()) {
- if (hide (pw))
- continue;
for (p = argv, ip = used; *p; ++p, ++ip)
! if (match(pw, *p)) {
enter_person(pw);
*ip = 1;
}
--- 261,268 ----
"finger: %s: no such user\n", *p);
else {
while (pw = getpwent()) {
for (p = argv, ip = used; *p; ++p, ++ip)
! if (match(pw, *p) && !hide(pw)) {
enter_person(pw);
*ip = 1;
}
>Audit-Trail:
>Unformatted:
finger checks every home directory for .nofinger
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199506212250.PAA11654>