Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Sep 2009 16:13:09 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Kris Kennaway <kris@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r197102 - head/sys/dev/amdtemp
Message-ID:  <200909141613.19957.jkim@FreeBSD.org>
In-Reply-To: <200909141608.53244.jkim@FreeBSD.org>
References:  <200909112147.n8BLlind064388@svn.freebsd.org> <200909141238.23995.jkim@FreeBSD.org> <200909141608.53244.jkim@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 14 September 2009 04:08 pm, Jung-uk Kim wrote:
> Please try the attached patch.  I tried to implement all the quirks
> in Revision Guide carefully but I must admit that I haven't tried
> it on anything earlier than Revision F.

This patch has one typo:

+       /*
+        * Errata #154: Incorect Diode Offset
+        */
+       if (cpu_id == 0x20f32) {
+               do_cpuid(0x80000001, regs);
+               if ((regs[1] && 0xfff) == 0x2c)
                             ^^
                             &
+                       sc->sc_flags |= AMDTEMP_FLAG_DO_QUIRK;
+       }

Today is not my day. :-(

Sorry again,

Jung-uk Kim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909141613.19957.jkim>