Date: Wed, 3 Mar 2010 00:28:33 -0800 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Alexandr Rybalko <ray@dlink.ua> Cc: Alex RAY <ray@ddteam.net>, current@freebsd.org Subject: Re: Call for Test and Review: bwn(4) - another Broadcom Wireless driver Message-ID: <20100303082833.GB22865@weongyo> In-Reply-To: <20100301103240.3a4aac8a.ray@dlink.ua> References: <20091223035331.GA1293@weongyo> <4b31cb29.9413f30a.5f4a.ffff8382@mx.google.com> <20100226005115.GP14937@weongyo> <20100227011535.ed3f2486.ray@ddteam.net> <20100228095259.GB3536@weongyo> <20100301103240.3a4aac8a.ray@dlink.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 01, 2010 at 10:32:40AM +0200, Alexandr Rybalko wrote: > On Sun, 28 Feb 2010 01:52:59 -0800 > Weongyo Jeong <weongyo.jeong@gmail.com> wrote: > > >> On Sat, Feb 27, 2010 at 01:15:35AM +0200, Alex RAY wrote: > >> > Hi Weongyo, > >> > > >> > Can new siba release operate in systems like in this SVG image? > >> > System example: CPU BCM5836 + Wi-Fi BCM4318 > >> > >> Recent changes of siba(4) by myself doesn't change code flow, layout and > >> doesn't include enhancements if you're an user of SENTRY5 mips CPU (like > >> BCM5836) > >> > >> All I did on recent changes were to put common routines or codes which > >> could be used for original siba(4). These codes are only used for > >> bwn(4) driver currently and don't be merged with original siba(4). That > >> means there are two separated codes in current siba(4) so merging two > >> into one is a TODO. > >> > >> I have no idea current siba(4) supports a system using on CPU BCM5836 + > >> Wi-Fi BCM4318 but in theory it should work without problems though I > >> didn't test. > >> > >> > And can we compile siba bus code without pci code? > >> > >> I think it looks that it could be possible to compile without pci code. > >> But makes sure that your device doesn't have PCI core. > > Can You test your driver without siba_switchcore, I see the device > have mapping for all cores on SSB? I see what you mean. siba_core.c which depends on PCI code would be compiled when it builds on SENTRY5. So it looks currently it needs a patch to compile siba bus code without PCI code. I'll try to make a patch. > > ssb0: <Broadcom BCM4315 802.11b/g Wireless> mem 0xf4000000-0xf4003fff > Think thre is 4 cores. > When SSB on nexus, we don`t need core switching, maybe on PCI too. I think this is a difference between siba(4) and siba_bwn currently and it's one of TODOs we should solve to merge two codes. AFAIK approach to access each cores isn't same; it looks siba(4) creates devices for each cores so it'd not need to switch cores. But siba_bwn doesn't do it like siba(4) so it needs to switch cores because all are handled on one device. regards, Weongyo Jeong
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100303082833.GB22865>