Date: Mon, 04 Feb 2008 18:09:18 +0200 From: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-stable@freebsd.org, freebsd-hardware@freebsd.org Subject: Re: ps/2 mouse patch Message-ID: <47A738AE.5070900@icyb.net.ua> In-Reply-To: <20080201093806.GA4632@suse.cz> References: <4799D78F.6000405@icyb.net.ua> <47A097FA.3090303@icyb.net.ua> <20080130164508.GC6257@suse.cz> <47A2E7E5.1040307@icyb.net.ua> <20080201093806.GA4632@suse.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------060302010604060102000307 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit on 01/02/2008 11:38 Vojtech Pavlik said the following: > On Fri, Feb 01, 2008 at 11:35:33AM +0200, Andriy Gapon wrote: >> I compared FreeBSD and Linux sources more thoroughly and found the >> following: >> http://lxr.linux.no/linux+v2.6.24/drivers/input/mouse/psmouse-base.c#L464 >> static int im_explorer_detect(struct psmouse *psmouse, int set_properties) >> { >> struct ps2dev *ps2dev = &psmouse->ps2dev; >> unsigned char param[2]; >> >> intellimouse_detect(psmouse, 0); >> >> I.e., first thing the explorer probe does is massaging a mouse with >> IntelliMouse magic commands. >> >> I did the same in FreeBSD psm.c, i.e., added a call to >> enable_msintelli() at the very start of enable_msexplorer(). And voilą - >> everything is perfect, correct ID is returned, probing succeeds, the >> mouse works great. >> >> I think that this change is quite safe to make in FreeBSD, because with >> Linux user-base we can be 99% percent sure that this change won't break >> anything. > > It is even correct: A mouse isn't required to be able to jump straight > into the Explorer mode, it is supposed to always go through the > IntelliMouse mode. Any takers to test this change with your current PS/2 mouse (either working or non-working) ? Any takers to commit this change ? :-) Will this issue get more traction if I file a PR? -- Andriy Gapon --------------060302010604060102000307 Content-Type: text/x-patch; name="psm.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="psm.c.patch" --- psm.c.orig 2008-02-04 18:07:34.000000000 +0200 +++ psm.c 2008-02-04 18:08:14.000000000 +0200 @@ -3109,6 +3109,8 @@ enable_msexplorer(struct psm_softc *sc) int id; int i; + enable_msintelli(sc); + /* the special sequence to enable the extra buttons and the roller. */ for (i = 0; i < sizeof(rate1)/sizeof(rate1[0]); ++i) { if (set_mouse_sampling_rate(kbdc, rate1[i]) != rate1[i]) --------------060302010604060102000307--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47A738AE.5070900>