Date: Fri, 01 May 2009 04:56:29 -0700 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Christoph Mallon <christoph.mallon@gmx.de> Cc: Ed Schouten <ed@FreeBSD.org>, FreeBSD Hackers <freebsd-hackers@FreeBSD.org>, Roman Divacky <rdivacky@FreeBSD.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: C99: Suggestions for style(9) Message-ID: <49FAE36D.9030109@FreeBSD.org> In-Reply-To: <49FA8F2D.5090708@gmx.de> References: <49F4070C.2000108@gmx.de> <20090428121327.GA41168@freebsd.org> <49FA8F2D.5090708@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Christoph Mallon wrote: > Roman Divacky schrieb: >> I like the part about using as many variables as possible because >> of documentation and performance enhancements. I tend to like >> the other changes as well.. > > This is not about using as many variables as possible. The goal is to > use as many variables as you have logically distinct entities in the > function. I suppose, this is what you mean, but I want to clarify this > point. Why don't just put "logically distinct entities" into separate functions on their own? It's a good indicator that the re-factoring is due when you reach this point. -Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49FAE36D.9030109>