Date: Fri, 11 Apr 2014 11:15:14 -0400 From: Steven Kreuzer <skreuzer@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r350132 - in head/security/p5-Crypt-Rabbit: . files Message-ID: <CAFFB%2BpTBy2Gztk11QL3DT%2BsYnafU1hNtn6CnQXyWdzjDjo_t_w@mail.gmail.com> In-Reply-To: <20140404151938.GA74064@FreeBSD.org> References: <201404041511.s34FBhLp047570@svn.freebsd.org> <20140404151938.GA74064@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 4, 2014 at 11:19 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Apr 04, 2014 at 03:11:43PM +0000, Steven Kreuzer wrote: >> New Revision: 350132 >> URL: http://svnweb.freebsd.org/changeset/ports/350132 >> QAT: https://qat.redports.org/buildarchive/r350132/ >> >> Log: >> Fix build on versions of FreeBSD that don't have gcc as the default >> compiler, remove the flag schedule-insns2 passed to cc >> >> +@@ -1,6 +1,6 @@ >> + use ExtUtils::MakeMaker; >> + >> +-my $opt = '-O3 -funroll-loops -fomit-frame-pointer -fschedule-insns2 -Os -fno-strength-reduce -Wall -pipe'; >> ++my $opt = '-O3 -funroll-loops -fomit-frame-pointer -Os -fno-strength-reduce -Wall -pipe'; > > Does it make sense to have both -O3 and -Os? Wouldn't it be better if it > simply uphold our standard $CFLAGS? Yeah, very good point. this has been fixed in revision 350979. Thanks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFFB%2BpTBy2Gztk11QL3DT%2BsYnafU1hNtn6CnQXyWdzjDjo_t_w>