Date: Fri, 21 Aug 2015 22:17:37 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394970 - head/devel/love07 Message-ID: <20150821191737.GB41937@hades.panopticon> In-Reply-To: <20150821185335.GA86849@FreeBSD.org> References: <201508211600.t7LG05HP050267@repo.freebsd.org> <20150821171523.GA49960@FreeBSD.org> <20150821172406.GA41937@hades.panopticon> <20150821185335.GA86849@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alexey Dokuchaev (danfe@FreeBSD.org) wrote:
> May I ask you to quote more accurately? It's hard to follow since I did not
> say anything about flavors (which, FWIW, were used purely as an example) in
> the second paragraph (which was essential, yet went unreplied).
>
> Apparently I did not make myself clear. I understand the "targets which
> depend on whether option is enabled or disabled" part; what I don't
> understand is the necessity of conditional installing of handful of text
> files whose existence does not depend on any option.
>
> After we entered staging era, we started to get rid of .if ${PORTDOCS}
> checks because we could use the benefit of dumping everything possible [1]
> into stagedir and then cherry-pick the bits we want to package (it can be
> one package or several depending on the options). These `post-install
> -DOCS-on: <install readmes and changelogs>' targets kind go against the
> idea of staging as it looks to me ATM unless I'm missing something obvious
> here.
Doc files are installed optionally based on DOCS option. Yes, the
framework handles them well by not including them into the package
if DOCS option is disabled, but there's no need to install them in
that case. Yes, not installing couple of files does not give any
build time improvements, but it's just more explicit and clean and
may be easily done with new optional targets.
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150821191737.GB41937>