Date: Sun, 25 Nov 2001 18:33:45 -0800 From: "John W. De Boskey" <jwd@FreeBSD.org> To: Arch List <freebsd-arch@FreeBSD.org> Subject: Comments on kern/32106 (MAXSHELLCMDLEN increase) Message-ID: <20011125183344.A1257@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/32106 This pr seems particulary straight forward. However, I believe the real problem lies in libc/gen/exec.c and it's handling of the ENOEXEC errno being returned from exec_shell_imgact(). ENOEXEC as a return code appears to be overloaded. A quick review of the code leads me to believe that exec_shell_imgact() could/should return E2BIG which is handled correctly in execvp() by dropping through to the done label and returning -1 (ie: the interpreter path is too big). As to the pr submitters original request, I do not see any earth shattering reasons why MAXSHELLCMDLEN can't be increased (if only to 128 and not 512). Comments? -john To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011125183344.A1257>