Date: Tue, 3 Jun 2014 23:45:00 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <FE2D881C-3A7E-441A-AFE0-FC2911E6100F@FreeBSD.org> In-Reply-To: <201406032106.s53L63oR085624@svn.freebsd.org> References: <201406032106.s53L63oR085624@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03 Jun 2014, at 21:06 , Alexander Motin <mav@FreeBSD.org> wrote: > Author: mav > Date: Tue Jun 3 21:06:03 2014 > New Revision: 267029 > URL: http://svnweb.freebsd.org/changeset/base/267029 >=20 > Log: > Replace gethrtime() with cpu_ticks(), as source of random for the = taskqueue > selection. gethrtime() in our port updated with HZ rate, so unusable = for > this specific purpose, completely draining benefit of multiple = taskqueues. >=20 > MFC after: 2 weeks >=20 I am seeing this now for all buildworld targets: = /storage/head/obj//arm.armeb/scratch/tmp/bz/head.svn/tmp/usr/lib/libzpool.= so: undefined reference to `cpu_ticks' > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun = 3 21:02:19 2014 (r267028) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun = 3 21:06:03 2014 (r267029) > @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t > if (tqs->stqs_count =3D=3D 1) { > tq =3D tqs->stqs_taskq[0]; > } else { > - tq =3D tqs->stqs_taskq[gethrtime() % tqs->stqs_count]; > + tq =3D tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count]; > } >=20 > taskq_dispatch_ent(tq, func, arg, flags, ent); >=20 =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FE2D881C-3A7E-441A-AFE0-FC2911E6100F>