Date: Tue, 17 Jan 2006 16:19:07 +0000 From: Doug Rabson <dfr@nlsystems.com> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci agp.c Message-ID: <AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE@nlsystems.com> In-Reply-To: <200601171111.01942.jhb@freebsd.org> References: <200512202106.jBKL6hNr035186@repoman.freebsd.org> <1CDDC33C-01D5-4AFE-99C0-DE848321D78B@nlsystems.com> <200601171111.01942.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Jan 2006, at 16:11, John Baldwin wrote: > On Tuesday 17 January 2006 06:51, Doug Rabson wrote: >> On 20 Dec 2005, at 21:06, John Baldwin wrote: >>> jhb 2005-12-20 21:06:43 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/pci agp.c >>> Log: >>> Change the agp_find_device() to return the first agp device that >>> has been >>> attached to a driver rather than always returning agp0. >> >> According to Coverity, this introduces a memory leak >> (devclass_get_devices() allocates memory). > > That it does. How about this fix: Looks good to me.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE>