Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 May 2007 14:22:44 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, "Ralf S. Engelschall" <rse@FreeBSD.org>, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/etc/rc.d hostid
Message-ID:  <200705211422.47842.jkim@FreeBSD.org>
In-Reply-To: <4651E084.1020605@FreeBSD.org>
References:  <200705211144.l4LBiEHY098477@repoman.freebsd.org> <4651E084.1020605@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 21 May 2007 02:10 pm, Doug Barton wrote:
> Ralf S. Engelschall wrote:
> > rse         2007-05-21 11:44:13 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     etc/rc.d             hostid
> >   Log:
> >   Adjust UUID lower-case translation from straight-forward tr(1)
> >   usage to an equivalent csh(1) usage as tr(1) stays in /usr/bin
> > and /etc/rc.d/hostid has just the root filesystem (and this way
> > mainly the tools in /bin) available.
> >
> >   I've chosen csh(1) here as the string manipulation tools
> > available in /bin is extremely limited and the (only) alternative
> > ed(1) usage would have been a lot more complicated or even might
> > require a temporary file.
> >
> >   Revision  Changes    Path
> >   1.4       +2 -1      src/etc/rc.d/hostid
> >
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/hostid.diff?&r
> >1=1.3&r2=1.4&f=h
>
> I really don't like the idea of having an rc.d script depend on
> csh. We don't have any other examples of that, and I don't really
> want to start down that road. I would appreciate it if you'd do a
> little more research into ways that this could be done with the
> tools available.
>
> Meanwhile, I've attached a patch that simplifies the
> hostid_hardware() quite a bit, and has the added virtue of only
> calling csh if it's needed.

Why don't we change smbios.system.uuid to all lower cases? ;-)
I have no problem with that.

Jung-uk Kim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705211422.47842.jkim>