Date: Sat, 22 Jan 2011 12:53:59 +0000 From: Chris Rees <utisoft@gmail.com> To: Jan Henrik Sylvester <me@janh.de> Cc: ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: Xournal: Please, help me with my first port Message-ID: <AANLkTimSe3wBQ_FPdfDtgcLH-bDXsDfX2AZ3hsD5Xff4@mail.gmail.com> In-Reply-To: <4D39FEBA.3000806@janh.de> References: <4D39FEBA.3000806@janh.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 January 2011 21:46, Jan Henrik Sylvester <me@janh.de> wrote: > Finally, I found an application worse having that is not in ports and looked > simple enough to try: Xournal is my first attempt to create a new port. > > I followed the handbook and did the basic testing with porttools: There are > warnings about considering to use DATADIR if the port was DATADIR-safe, but > I do not assume it to be. > > Moreover, there is a warning about my post-patch line. I think the warning > is wrong, but I am unsure about that line anyhow. The desktop-install target > in Makefile.in is wrong for FreeBSD, but there is probably a better way to > fix it. > > Is my attempt to use the desktop-install target via post-install correct? > > Do all the files installed by the post-install target go to the correct > locations? > > Is there anything else I should fix before submitting the port as pr? > > In case the attachment does not make it to the list, I have placed a copy > here: http://www.math.uni-hamburg.de/home/sylvester/xournal.shar > The DATADIR whines are addressed in this patch, have a look: http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff That's all I had time to look at at the moment, perhaps others can help! Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimSe3wBQ_FPdfDtgcLH-bDXsDfX2AZ3hsD5Xff4>