Date: Tue, 9 Mar 2010 00:35:28 GMT From: Benjamin Lee <ben@b1c1l1.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/144567: graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive Message-ID: <201003090035.o290ZSBK041172@www.freebsd.org> Resent-Message-ID: <201003090040.o290e3X0074878@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 144567
>Category: ports
>Synopsis: graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 09 00:40:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Benjamin Lee
>Release: 8.0-RELEASE-p2
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan 5 16:02:27 UTC 2010 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Currently, the graphics/gd port can only build with fontconfig support (via the WITH_FONTCONFIG knob) if WITHOUT_X11 is not defined.
This is an unnecessary restriction, as gd can build with fontconfig support on machine built with WITHOUT_X11 defined.
>How-To-Repeat:
Build graphics/gd with both WITHOUT_X11 and WITH_FONTCONFIG defined.
>Fix:
Apply the attached patch.
Patch attached with submission follows:
--- /usr/ports/graphics/gd/Makefile 2010-02-05 03:38:31.000000000 -0800
+++ Makefile 2010-03-08 16:30:11.000000000 -0800
@@ -50,6 +50,8 @@
FEATURES+= GD_XPM
.endif
+.endif
+
.if defined(WITH_FONTCONFIG)
LIB_DEPENDS+= fontconfig.1:${PORTSDIR}/x11-fonts/fontconfig
CPPFLAGS+= -I${LOCALBASE}/include -DHAVE_LIBFONTCONFIG -DHAVE_PTHREAD ${PTHREAD_CFLAGS}
@@ -58,8 +60,6 @@
FEATURES+= GD_FONTCONFIG
.endif
-.endif
-
.if defined(WITH_ICONV)
USE_ICONV= yes
CPPFLAGS+= -DHAVE_ICONV -DHAVE_ICONV_H -DHAVE_ICONV_T_DEF
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003090035.o290ZSBK041172>