Date: Mon, 15 Dec 2014 16:38:04 -0500 From: Ed Maste <emaste@freebsd.org> To: Craig Rodrigues <rodrigc@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r275804 - head/gnu/usr.bin/cc/cc1plus Message-ID: <CAPyFy2D3GHFk=daKia6psn-TjjtGthzAiYHghVuPk778nXqZrw@mail.gmail.com> In-Reply-To: <CAG=rPVc3GJpCGSBUD4-TgfKG2HVHt=oEr71G_twChx6_x7tBGQ@mail.gmail.com> References: <201412151425.sBFEPhhs009026@svn.freebsd.org> <CAG=rPVc3GJpCGSBUD4-TgfKG2HVHt=oEr71G_twChx6_x7tBGQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 December 2014 at 16:04, Craig Rodrigues <rodrigc@freebsd.org> wrote:
>
>
> On Mon, Dec 15, 2014 at 6:25 AM, Ed Maste <emaste@freebsd.org> wrote:
>>
>> cfns.h: cfns.gperf
>> gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
>> - ${.ALLSRC} > ${.TARGET}
>> + ${.ALLSRC} > ${.TARGET} || (rm -f ${.TARGET}; false)
>>
>
> Instead of removing the target you could have done something like:
>
> cfns.h: cfns.gperf
> gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
> ${.ALLSRC} > ${.TARGET}_temp
> mv ${.TARGET}_temp ${.TARGET}
Yeah. There are already examples of both approaches in the tree; I
don't see a reason to strongly prefer one over the other.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2D3GHFk=daKia6psn-TjjtGthzAiYHghVuPk778nXqZrw>