Date: Sat, 17 May 2003 15:05:49 +0200 From: Erik Trulsson <ertr1013@student.uu.se> To: Jonathan Belson <jon@witchspace.com> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: FreeBSD Port: pornview-0.2.0.p.1 Message-ID: <20030517130549.GA44928@falcon.midgard.homeip.net> In-Reply-To: <3EC62CC2.6090209@witchspace.com> References: <3EC53C6C.1040904@witchspace.com> <20030517121908.GA67369@rot13.obsecurity.org> <3EC62CC2.6090209@witchspace.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 17, 2003 at 01:36:18PM +0100, Jonathan Belson wrote: > Kris Kennaway wrote: > >The package builds currently fail on 4.x: > > > >http://bento.freebsd.org/errorlogs/i386-4-latest/pornview-0.2.0.p.1_1.log > > > >Your workaround does not sound like a solution though. stdin et al > >are defined for a reason ;-) > > The problem is in the following structure: > > struct ChildContext_Tag > { > ...blah... > int stdout_fd; > int stderr_fd; > int stdin_fd; That part of the structure is not the problem. The next part of this structure is the problem. gchar stdout[GTK_MPLAYER_BUF_SIZE]; gint stdout_size; gchar stderr[GTK_MPLAYER_BUF_SIZE]; gint stderr_size; This code is faulty since stdin/stdout/stderr *are* macros and therefore *will* mess up this declaration. > ...blah... > }; > > The author's (perfectly legitimate) members are being mangled by Not legitimate. The C standard itself says that stdin/stdout/stderr are supposed to be macros and therefore this behaviour is expected. > the preprocessor. It seems a little unfair to ask the author to > change them, the only other alternative I can see is to s/// every The bug is in the application, not in FreeBSD, so, unfair or not, it isn't FreeBSD that should be changed. > reference to something that doesn't clash with the FreeBSD stdio.h. > > Ugly :-( > > > --Jon > > http://www.witchspace.com > > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" -- <Insert your favourite quote here.> Erik Trulsson ertr1013@student.uu.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030517130549.GA44928>