Date: Fri, 10 Oct 2014 19:59:16 +0400 From: Andrey Chernov <ache@freebsd.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-stable@freebsd.org, bapt@FreeBSD.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r270122 - in stable/10: . lib/libopie Message-ID: <54380254.3090702@freebsd.org> In-Reply-To: <5437F8A0.4080905@freebsd.org> References: <201408180242.s7I2gNaq087095@svn.freebsd.org> <20141010144747.GH19486@ivaldir.etoilebsd.net> <5437F373.1090300@freebsd.org> <20141011.000201.1863876266089528066.hrs@allbsd.org> <5437F71E.1090701@freebsd.org> <5437F8A0.4080905@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 10.10.2014 19:17, Andrey Chernov wrote: > On 10.10.2014 19:11, Andrey Chernov wrote: >> On 10.10.2014 19:02, Hiroki Sato wrote: >>> ac> It is strange that nobody notice that so far. Is there any packag= es >>> ac> which builds with libopie? If no, there is no problem. If yes, wh= at you >>> >>> cyrus-sasl uses it. >>> >>> ac> suggest to fix, is that backing out? If yes, when exactly this ch= ange >>> ac> can be merged to -stable (because -stable always stays -stable, s= o from >>> ac> your sentence it means - never can be merged). >>> >>> Is it impossible to handle this by symbol versioning instead of shli= b >>> version bump? >> >> There is buffer size #define change (it was too small in unfixed >> version, so discards valid input), the buffer itself is in the userlan= d >> programs, not in the library. AFAIK symbol versioning is for functions= , >> not for such changes but I can be wrong, I know very little about symb= ol >> versioning procedure. >=20 > From other hand, the check for buffer size is in the library, so the > function which does the check can be versioned, but I still don't know > how exactly to do that. >=20 It does not help in general case. Such checks can be in the userland too. So, backing out buffer size change and major version bump for -stable, right? --=20 http://ache.vniz.net/ --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJUOAJVAAoJEKUckv0MjfbK77gIAI7cGviTYNwTa4DbDRqk7Lnu kfKp2xbfzz8zSAkw16w0LsRbC0vGjN1CtOH6auy6D4C8gw0tgFRT50BVGbkzjNds Yx7Ir6McjJ3YOCE4Kl73ezoOALWYEyZh36rKvp3n7vTS4Ow6uuSlulyuNlGJz1mX htrrTpvR5aVPTMrWMirBHCcop4b3sdsUCNrYrFQyf5FrA7d0pqD8Fvq+7s7RipNC S9onp7nH/5prp/5F/NvQKfHH00FiPqlDzCFnH06E5hml4EF0sNPruyZENXJIijk2 kJt79UZxkm2+ddKDflyCrAGYiJNjq/N4h/YHed5bKjsSI4Dt2DrxwuUlPdFSizM= =es/J -----END PGP SIGNATURE----- --C4bHrobAT0LTejDQChRd22UTOmDX8GPxO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54380254.3090702>