Date: Fri, 26 Apr 2002 02:12:23 +0100 From: Brian Somers <brian@freebsd-services.com> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: Harti Brandt <brandt@fokus.gmd.de>, brian@freebsd.org, current@freebsd.org Subject: Re: Revision 1.88 of kern_linker.c breaks module loading for diskless Message-ID: <200204260112.g3Q1CNxH066034@hak.lan.Awfulhak.org> In-Reply-To: Message from Ian Dowse <iedowse@maths.tcd.ie> of "Fri, 26 Apr 2002 01:09:16 BST." <200204260109.aa01691@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
> In message <20020425184846.Q795-100000@beagle.fokus.gmd.de>, Harti Brandt write > s: > >the check for rootdev != NODEV introduced in rev 1.88 breaks loading of > >kernel modules from an NFS mounted root in diskless configurations. > >Dropping in gdb and printing rootdev shows -1 which is, I assume, NODEV. > > Ah, that would explain a problem I saw recently on a netbooted box > where kldload only worked with full module paths. Could `rootvnode' > be checked for NULL instead? Hi, The intent is to discover whether there's a filesystem yet (vn_open() will die horribly otherwise). My use of rootdev is (obviously) flawed. AFAICT, either rootvp or rootvnode should be used, but I can't tell the difference between the two at a glance and am lacking development resources right now (my development box seems to enjoy dropping cores too frequently to build a kernel at the moment). If somebody could test that rootvnode or rootvp are non-NULL after an NFS-mounted root is set up, I'd thankfully approve the quick fix... :*) Cheers. > Ian -- Brian <brian@freebsd-services.com> <brian@Awfulhak.org> http://www.freebsd-services.com/ <brian@[uk.]FreeBSD.org> Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204260112.g3Q1CNxH066034>