Date: Thu, 1 Sep 2011 17:28:13 -0400 From: John Baldwin <jhb@freebsd.org> To: Robert Millan <rmh@debian.org> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Fix NKPT kernel config option Message-ID: <201109011728.13979.jhb@freebsd.org> In-Reply-To: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com> References: <CAOfDtXPDAyeZX7adW5Hixa2XwyOFgic=FRU6ipUHZcY15JVQaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, September 01, 2011 3:46:43 pm Robert Millan wrote: > Hi John, > > Thanks for adding an NKPT kernel config option (r225194), but this > doesn't seem to work unless opt_pmap.h is included, see attached > patch. > > Without this include, there's no garantee that the NKPT definition code: > > #ifndef NKPT > #define NKPT 32 > #endif > > will use the value specified in config. Or worse, it may even use > different values for different .c files. > > -- > Robert Millan In general we force the relevant C files to use opt_*.h includes and avoid nested includes of those in headers. Do you know of any C files that do are using NKPT (or values derived from it) without including opt_pmap.h? I thought they were all covered in the commit. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109011728.13979.jhb>