Date: Fri, 18 Nov 2011 13:29:09 -0800 From: Doug Barton <dougb@FreeBSD.org> To: d@delphij.net Cc: freebsd-rc@freebsd.org, Xin LI <delphij@delphij.net> Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface Message-ID: <4EC6CE25.7000704@FreeBSD.org> In-Reply-To: <4EC6CA02.5090606@delphij.net> References: <4EB6693F.2020102@delphij.net> <4EB71580.20507@FreeBSD.org> <4EB72290.8030104@delphij.net> <Snqh5lmyPm2YvkGpN1vSomauXwU@g5jH1yj%2BTnAiSdLOy3xs5Jutvhc> <4EC6C247.6040807@delphij.net> <VMhPQj/s0331SNZXLVpdbaNAyBY@RzV33t0qf/tQbqPDH2EX0VmGCGw> <4EC6C50F.30405@FreeBSD.org> <4EC6CA02.5090606@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/18/2011 13:11, Xin LI wrote: > On 11/18/11 12:50, Doug Barton wrote: >> On 11/18/2011 12:45, Eygene Ryabinkin wrote: >>> Xin, good day. >>> >>> Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote: >>>> Is there any counter reasoning about "having an interface >>>> marked as non-DHCP is not an error"? I'm still not convinced >>>> with the benefit of having it show an error message. >>> >>> Well, when I invoke 'service dhclient start em0' and em0 isn't >>> DHCP-enabled, I want to see some diagnostics on why I was not >>> able to get DHCP on that interface. Return code isn't that >>> visible (I can, of course, always run it as 'service dhclient >>> start em0 || echo failed'), but I am not up to typing more than >>> needed and I should see the real reason for absence of >>> DHCP-assigned address in that case, be it the non-DHCP-enabled >>> interface or some other problem. > >> Right, that's my argument as well. > >> If there is a particular code path that leads to attempting >> dhclient on a non-dhcp interface I'd rather see that code path >> fixed than to suppress the warning. > > Do you have any objection to rea@'s version of patch? I already said I did, yes. Fix the real problem, don't paper over the symptom. -- "We could put the whole Internet into a book." "Too practical." Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EC6CE25.7000704>