Date: Wed, 23 Mar 2016 11:18:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 207929] [NEW PORT] biology/jellyfish: Fast, memory-efficient counting of k-mers in DNA Message-ID: <bug-207929-13-tTjUWG84Fy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-207929-13@https.bugs.freebsd.org/bugzilla/> References: <bug-207929-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207929 Raphael Kubo da Costa <rakuco@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #2 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- Some suggestions after a quick review: * You can drop the pkg-config sed call and replace it with USES=3Dpathfix a= nd PATHFIX_MAKEFILEIN=3DMakefile.am. * The version and architecture checks can be simplified: 1. Use a helper to mark the port as broken: BROKEN_FreeBSD_9_i386=3D multiple code issues on i386 < 10.0-RELEASE 2. Use MACHINE_CPU to check if the CPU supports SSE: .if empty(MACHINE_CPU:sse) CONFIGURE_ARGS+=3D --without-sse .endif This also allows you to just include bsd.port.mk. * BUILD_DEPENDS+=3D should be BUILD_DEPENDS=3D * Should --without-sse work on amd64? I tried passing it here and the build failed. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207929-13-tTjUWG84Fy>