Date: Wed, 19 Feb 2003 15:35:13 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Sam Leffler <sam@errno.com> Cc: Maxime Henrion <mux@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20030219153513.A3364@Odin.AC.HMC.Edu> In-Reply-To: <0b4101c2d864$49cbafd0$52557f42@errno.com>; from sam@errno.com on Wed, Feb 19, 2003 at 02:14:35PM -0800 References: <200302191833.h1JIXT2d013173@repoman.freebsd.org> <0b4101c2d864$49cbafd0$52557f42@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 19, 2003 at 02:14:35PM -0800, Sam Leffler wrote: > > We should probably move all the other DMA map creations in > > xl_attach() where we can really handle them failing, since > > xl_init() is void and shouldn't fail. >=20 > When I did the struct ifnet fixups I almost changed if_init from void to = int > to return an error code. Maybe it's not too late to do this before the > REELNG_5 branch? Personaly, I'd like to make the switch to if_xname as well so breaking the struct ifnet API is fine with me. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+VBSwXY6L6fI4GtQRAtM+AKDYRlnZjaW18QV3svIkQHbzxBE6bQCghMeU /09orytPgdy8LeyOc3afBgY= =f3x2 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030219153513.A3364>