Date: Fri, 15 May 2009 13:11:20 -0700 From: Kip Macy <kmacy@freebsd.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-fs@freebsd.org Subject: Re: stable/7: shutdown stuck in zfs_umount (z_op_cnt > 0) Message-ID: <3c1674c90905151311jc3cc9a8jb60eb526d849a616@mail.gmail.com> In-Reply-To: <4A0D6276.2080902@icyb.net.ua> References: <4A0D48CB.7030707@icyb.net.ua> <4A0D5E64.1050500@icyb.net.ua> <4A0D6276.2080902@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 15, 2009 at 5:39 AM, Andriy Gapon <avg@icyb.net.ua> wrote: > on 15/05/2009 15:21 Andriy Gapon said the following: >> Red herring or not (I don't see the general picture of zfs code), but it seems >> that there is no ZFS_EXIT for return at the end of zfsctl_snapdir_lookup function. >> >> P.S. C++ RAII could have been handy in this case [or not] :-) > > Couple of notes: > 1. this doesn't appear to be a red herring as ZFS_EXIT before the last return > statement can be found in head > 2. yes, I do mount snapshots from time to time (backups, etc) > Thanks for the bug reports. Unfortunately, pjd is very busy and I do not intend to track down bugs in a very old version of ZFS. Your best bet will be to test the MFC patch when it is ready in a day or two. Cheers, Kip
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c1674c90905151311jc3cc9a8jb60eb526d849a616>