Date: Wed, 26 May 2010 03:32:24 -0400 From: Randall Stewart <rrs@lakerest.net> To: Neel Natu <neelnatu@gmail.com> Cc: freebsd-mips@freebsd.org Subject: Re: Fixes to the new pagetable page allocation code. Message-ID: <35D2DD59-83B6-4D7A-9619-E29424ABEDF1@lakerest.net> In-Reply-To: <AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at@mail.gmail.com> References: <AANLkTiluuD6YtgYBRj25FixyzGyrGNwQZmvB_nOeCFWN@mail.gmail.com> <AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
JC: It looks good to me too ;-) R On May 26, 2010, at 1:30 AM, Neel Natu wrote: > Hi JC, > > On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran > <c.jayachandran@gmail.com> wrote: >> The attached patch (also at >> http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff) >> has two fixes for the new pagetable page allocation code, one to >> handle NULL return from the allocating function, and another to call >> VM_WAIT in cases we can wait. It also removes the variable 'req' left >> over from an earlier change. >> >> Please let me know if you have any comments... >> > > Your patch looks fine. > > Checking the value of 'ptdpg' is redundant given that you are passing > in M_WAITOK. I don't think we expect the allocation to fail now that > you have added the check for M_WAITOK in zone allocator function. > > best > Neel > >> JC. >> > ------------------------------ Randall Stewart 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35D2DD59-83B6-4D7A-9619-E29424ABEDF1>