Date: Fri, 18 Sep 2009 09:47:52 -0700 From: Julian Elischer <julian@elischer.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, Marko Zec <zec@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r197286 - head/sys/net Message-ID: <4AB3B9B8.4060600@elischer.org> In-Reply-To: <20090918121233.GB3650@garage.freebsd.pl> References: <200909171452.n8HEqFfs061011@svn.freebsd.org> <20090917151723.GB2197@garage.freebsd.pl> <20090918005831.B68375@maildrop.int.zabbadoz.net> <20090918121233.GB3650@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek wrote: > On Fri, Sep 18, 2009 at 12:59:49AM +0000, Bjoern A. Zeeb wrote: >> On Thu, 17 Sep 2009, Pawel Jakub Dawidek wrote: >> >>> On Thu, Sep 17, 2009 at 02:52:15PM +0000, Marko Zec wrote: >>>> Author: zec >>>> Date: Thu Sep 17 14:52:15 2009 >>>> New Revision: 197286 >>>> URL: http://svn.freebsd.org/changeset/base/197286 >>>> >>>> Log: >>>> V_irtualize the lltables list, making ARP and ND reasonably >>>> usable again with options VIMAGE kernels. >>>> >>>> Submitted by: bz (the original version, probably identical to this >>>> one) >> Uncommitted for the reason to not interfere with bugfixing for 8.0-R. >> >>>> Reviewed by: many @ DevSummit Cambridge >>>> MFC after: 3 days >>> [...] >>>> +static void >>>> +vnet_lltable_init() >>>> +{ >>>> + >>>> + SLIST_INIT(&V_lltables); >>>> +} >>>> +VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, >>>> vnet_lltable_init, NULL); >> ANy I didn'thave this style bug;) >> >>> There is nothing we want to do when vnet is going away? >> No things will clear itself up via other ways as the interfaces will >> go away the table will empty itself, etc > > So I guess it won't hurt to assert on uninit that the list is really > empty?:) > not a bad idea.. is there already an UNINIT? it may be the only user.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AB3B9B8.4060600>