Date: Mon, 11 Nov 2013 14:19:38 -0500 From: Eitan Adler <eadler@freebsd.org> To: Bryan Drewery <bryan@shatow.net> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r257945 - head/usr.sbin/pkg Message-ID: <CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw@mail.gmail.com> In-Reply-To: <20131111153544.GI98118@admin.xzibition.com> References: <201311110744.rAB7iA6g041490@svn.freebsd.org> <20131111153544.GI98118@admin.xzibition.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 11, 2013 at 10:35 AM, Bryan Drewery <bryan@shatow.net> wrote: > On Mon, Nov 11, 2013 at 07:44:10AM +0000, Gleb Smirnoff wrote: >> Author: glebius >> Date: Mon Nov 11 07:44:09 2013 >> New Revision: 257945 >> URL: http://svnweb.freebsd.org/changeset/base/257945 >> >> Log: >> Do not use just freed memory. >> >> Sponsored by: Nginx, Inc. > > Can you please also MFC this? > >> if (fingerprint->name) >> free(fingerprint->name); While here, can you remove the if conditional by the free? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgm73FnyFgGcD2YA0MZ3Q=sHpqmS3QAbsP8BV2Qyx2z7mw>