Date: Thu, 9 Sep 2010 16:24:16 -0400 From: John Baldwin <jhb@freebsd.org> To: mdf@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212368 - head/sys/dev/pci Message-ID: <201009091624.17060.jhb@freebsd.org> In-Reply-To: <AANLkTikx=cDTnxseNTpLYeq2urwsc393E-FSDzKHmHEe@mail.gmail.com> References: <201009091819.o89IJGLr015797@svn.freebsd.org> <AANLkTikx=cDTnxseNTpLYeq2urwsc393E-FSDzKHmHEe@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, September 09, 2010 4:10:55 pm mdf@freebsd.org wrote: > On Thu, Sep 9, 2010 at 11:19 AM, John Baldwin <jhb@freebsd.org> wrote: > > Author: jhb > > Date: Thu Sep 9 18:19:15 2010 > > New Revision: 212368 > > URL: http://svn.freebsd.org/changeset/base/212368 > > > > Log: > > - Rename the constant for the Master Data Parity Error flag in the > > PCI status register to map its current name. > > - Use PCIM_* rather than PCIR_* for constants for fields in various AER > > registers. I got about half of them right in the previous commit. > > > > MFC after: 1 week > > > > Modified: > > head/sys/dev/pci/pcireg.h > > This seems to break building CURRENT with this error: > > /data/sb/bsd.git/sys/dev/msk/if_msk.c: In function 'mskc_reset': > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: > 'PCIM_STATUS_PERRREPORT' undeclared (first use in this function) > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: (Each undeclared > identifier is reported only once > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: for each function > it appears in.) > /data/sb/bsd.git/sys/dev/msk/if_msk.c: In function 'msk_intr_hwerr': > /data/sb/bsd.git/sys/dev/msk/if_msk.c:3408: error: > 'PCIM_STATUS_PERRREPORT' undeclared (first use in this function) My bad, I will fix. Surprised a driver is even messing with this bit as only the PCI bus driver should really be doing so (if it grows error handling ability). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009091624.17060.jhb>