Date: Thu, 30 Dec 2010 13:02:50 +0300 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/153540: [patch] multimedia/ffmpeg: respect STRIP Message-ID: <86zkrnd1dh.fsf@gmail.com> Resent-Message-ID: <201012301010.oBUAA957084246@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 153540
>Category: ports
>Synopsis: [patch] multimedia/ffmpeg: respect STRIP
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 30 10:10:08 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
cf. ports/150689
>Description:
- don't strip debug binaries[1]
- use yasm debug flags for WITH_DEBUG
[1] unless ports/153539 is fixed WITH_DEBUG needs either STRIP
explicitly re-defined or DEBUG_FLAGS defined
>How-To-Repeat:
$ make install WITH_DEBUG=
$ STRIP= make install
$ file PREFIX/lib/libavcodec.so.*.*.*
/usr/local/lib/libavcodec.so.52.72.2: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, stripped
>Fix:
--- a.diff begins here ---
Index: multimedia/ffmpeg/Makefile
===================================================================
RCS file: /a/.cvsup/ports/multimedia/ffmpeg/Makefile,v
retrieving revision 1.121
diff -u -p -r1.121 Makefile
--- multimedia/ffmpeg/Makefile 29 Dec 2010 21:41:36 -0000 1.121
+++ multimedia/ffmpeg/Makefile 30 Dec 2010 09:50:52 -0000
@@ -91,8 +91,7 @@ CONFIGURE_ARGS+=--prefix="${PREFIX}" \
--cc="${CC}" \
--extra-cflags="${FFMPEG_CFLAGS} -I${LOCALBASE}/include" \
--extra-ldflags="-L${LOCALBASE}/lib ${FFMPEG_LDFLAGS}" \
- --extra-libs="${PTHREAD_LIBS}" \
- --disable-debug
+ --extra-libs="${PTHREAD_LIBS}"
SHLIB_VER= 1
PLIST_SUB= SHLIB_VER=${SHLIB_VER}
USE_LDCONFIG= yes
@@ -109,6 +108,14 @@ DOC_DOCFILES= APIchanges TODO avutil.txt
snow.txt soc.txt swscale.txt tablegen.txt viterbi.txt
PORTDOCS= *
+.if !defined(WITH_DEBUG)
+CONFIGURE_ARGS+= --disable-debug
+.endif
+
+.if !defined(STRIP) || ${STRIP} == ""
+CONFIGURE_ARGS+= --disable-stripping
+.endif
+
.if !defined(WITHOUT_CPUDETECT)
CONFIGURE_ARGS+= --enable-runtime-cpudetect
.endif
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zkrnd1dh.fsf>