Date: Fri, 26 Jul 2013 23:31:48 -0700 From: Craig Rodrigues <rodrigc@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, Marko Zec <zec@fer.hr>, "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org>, freebsd-pf@freebsd.org Subject: De-virtualize V_pf_mtag_z to eliminate kernel panics. Message-ID: <CAG=rPVdkpj6mPs=nR_%2B3snb14RUA44pDgSMQkZC9vnBP%2BibCGA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--047d7b472746ef40e904e278696f Content-Type: text/plain; charset=ISO-8859-1 Gleb, Since you did a lot of work in GRN 240233 to fix PF issues, especially for VIMAGE, I thought I would ask your opinion on the attached patch. In this post: http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001405.html I reported multiple PF-related panics when VIMAGE was enabled in my kernel config. In these posts: http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001413.html http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001420.html Marko Zec seemed to think that de-virtualizing V_pf_mtag_z would be a valid solution to this problem, and that keeping V_pf_mtag_z as a per-vnet variable is not necessary. What do you think of Marko's comments, and this patch? Thanks. -- Craig --047d7b472746ef40e904e278696f Content-Type: text/plain; charset=US-ASCII; name="diff.txt" Content-Disposition: attachment; filename="diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hjmfwbmu0 SW5kZXg6IHN5cy9uZXRwZmlsL3BmL3BmLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25ldHBmaWwvcGYv cGYuYwkocmV2aXNpb24gMjUzMzQ2KQorKysgc3lzL25ldHBmaWwvcGYvcGYuYwkod29ya2luZyBj b3B5KQpAQCAtMTg3LDggKzE4Nyw3IEBACiAKIHN0YXRpYyBWTkVUX0RFRklORSh1bWFfem9uZV90 LAlwZl9zb3VyY2VzX3opOwogI2RlZmluZQlWX3BmX3NvdXJjZXNfeglWTkVUKHBmX3NvdXJjZXNf eikKLXN0YXRpYyBWTkVUX0RFRklORSh1bWFfem9uZV90LAlwZl9tdGFnX3opOwotI2RlZmluZQlW X3BmX210YWdfeglWTkVUKHBmX210YWdfeikKK3VtYV96b25lX3QgcGZfbXRhZ196OwogVk5FVF9E RUZJTkUodW1hX3pvbmVfdCwJIHBmX3N0YXRlX3opOwogVk5FVF9ERUZJTkUodW1hX3pvbmVfdCwJ IHBmX3N0YXRlX2tleV96KTsKIApAQCAtNzQ5LDcgKzc0OCw3IEBACiAJVl9wZl9hbHRxc19pbmFj dGl2ZSA9ICZWX3BmX2FsdHFzWzFdOwogCiAJLyogTWJ1ZiB0YWdzICovCi0JVl9wZl9tdGFnX3og PSB1bWFfemNyZWF0ZSgicGYgbXRhZ3MiLCBzaXplb2Yoc3RydWN0IG1fdGFnKSArCisJcGZfbXRh Z196ID0gdW1hX3pjcmVhdGUoInBmIG10YWdzIiwgc2l6ZW9mKHN0cnVjdCBtX3RhZykgKwogCSAg ICBzaXplb2Yoc3RydWN0IHBmX210YWcpLCBOVUxMLCBOVUxMLCBwZl9tdGFnX2luaXQsIE5VTEws CiAJICAgIFVNQV9BTElHTl9QVFIsIDApOwogCkBAIC04MDMsNyArODAyLDcgQEAKIAltdHhfZGVz dHJveSgmcGZfb3ZlcmxvYWRxdWV1ZV9tdHgpOwogCW10eF9kZXN0cm95KCZwZl91bmxua2RydWxl c19tdHgpOwogCi0JdW1hX3pkZXN0cm95KFZfcGZfbXRhZ196KTsKKwl1bWFfemRlc3Ryb3kocGZf bXRhZ196KTsKIAl1bWFfemRlc3Ryb3koVl9wZl9zb3VyY2VzX3opOwogCXVtYV96ZGVzdHJveShW X3BmX3N0YXRlX3opOwogCXVtYV96ZGVzdHJveShWX3BmX3N0YXRlX2tleV96KTsKQEAgLTgyNyw3 ICs4MjYsNyBAQAogcGZfbXRhZ19mcmVlKHN0cnVjdCBtX3RhZyAqdCkKIHsKIAotCXVtYV96ZnJl ZShWX3BmX210YWdfeiwgdCk7CisJdW1hX3pmcmVlKHBmX210YWdfeiwgdCk7CiB9CiAKIHN0cnVj dCBwZl9tdGFnICoKQEAgLTgzOCw3ICs4MzcsNyBAQAogCWlmICgobXRhZyA9IG1fdGFnX2ZpbmQo bSwgUEFDS0VUX1RBR19QRiwgTlVMTCkpICE9IE5VTEwpCiAJCXJldHVybiAoKHN0cnVjdCBwZl9t dGFnICopKG10YWcgKyAxKSk7CiAKLQltdGFnID0gdW1hX3phbGxvYyhWX3BmX210YWdfeiwgTV9O T1dBSVQpOworCW10YWcgPSB1bWFfemFsbG9jKHBmX210YWdfeiwgTV9OT1dBSVQpOwogCWlmICht dGFnID09IE5VTEwpCiAJCXJldHVybiAoTlVMTCk7CiAJYnplcm8obXRhZyArIDEsIHNpemVvZihz dHJ1Y3QgcGZfbXRhZykpOwo= --047d7b472746ef40e904e278696f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVdkpj6mPs=nR_%2B3snb14RUA44pDgSMQkZC9vnBP%2BibCGA>