Date: Thu, 15 Apr 2010 09:13:50 -0400 From: John Baldwin <jhb@freebsd.org> To: pluknet <pluknet@gmail.com> Cc: freebsd-current@freebsd.org, Nathan Whitehorn <nwhitehorn@freebsd.org> Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 Message-ID: <201004150913.50097.jhb@freebsd.org> In-Reply-To: <i2ka31046fc1004150306l619e5b2btc158df99f06627f3@mail.gmail.com> References: <20100312171758.GB31089@dragon.NUXI.org> <201004071549.41672.jhb@freebsd.org> <i2ka31046fc1004150306l619e5b2btc158df99f06627f3@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 15 April 2010 6:06:24 am pluknet wrote: > On 7 April 2010 23:49, John Baldwin <jhb@freebsd.org> wrote: > > On Tuesday 06 April 2010 11:24:21 am Nathan Whitehorn wrote: > >> pluknet wrote: > >> > Hi, > >> > > >> > the interesting part for me is how to properly assert now a value of e.g. > >> > KINFO_PROC_SIZE varying on err.. different COMPAT_FREEBSD32 arches > >> > (say, FreeBSD would have _kern_proc FreeBSD32 compat layer for top/ps/). > >> > > >> > > >> Probably the cleanest thing would be to set KINFO_PROC_SIZE in > >> machine/proc.h instead of where it is now, and then also define a > >> KINFO_PROC32_SIZE or something in the same place. Also, that would be a > >> really nice feature. > > > > Yes, I think this sounds like the best approach. > > > > Something quick & not clean (well, it passes universe) attached. > So, don't shoot me, please ;-). > It's unclear how to convert those mips o32/n32/o64/n64 though. > I had to make definitions out of _KERNEL visibility as far as > <sys/proc.h> is included from <sys/user.h> in !_KERNEL only too. Just one suggestion: don't make KINFO_PROC32 #define depenedent on COMPAT_FREEBSD32. It should just be always defined. I think that is the approach Nathan used for the 32-bit ELF machine type. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004150913.50097.jhb>