Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Jan 2006 16:53:07 +0100
From:      Alexander Leidinger <Alexander@Leidinger.net>
To:        Boris Samorodov <bsam@ipt.ru>
Cc:        emulation@freebsd.org, paul beard <paulbeard@mac.com>
Subject:   Re: having some trouble with linux-pango
Message-ID:  <20060111165307.lz00xrvhw8w8okok@netchild.homeip.net>
In-Reply-To: <71140889@srv.sem.ipt.ru>
References:  <EBA3AA9B-EBD3-4674-B558-F5D298B84506@mac.com> <20060110202542.7e049c4c@Magellan.Leidinger.net> <DF18B53D-B1AF-486C-A55A-84F248118634@mac.com> <20060111095954.c710azp5c0wwwkcg@netchild.homeip.net> <71140889@srv.sem.ipt.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
Boris Samorodov <bsam@ipt.ru> wrote:

> Yes, there is a PR on the matter:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/85254
>
> Pay attention to followups.

The linux X11 port was modifying a file which belongs to the linux_base port.
The value it added was fixed (the path to the linux X11 lib directory) and
doesn't result in any breakage when added in the linux_base port.

Modifying the contents of a file which does belong to another port results in
warnings because of a changed MD5 sum when the file is deinstalled without
the removal of the corresponding line by the port which added the line.
Files from other ports shouldn't be touched if not absolutely necessary.

Additionally the linux X11 port not only added one directory, it generated
the file completely at install time (so it was possible to add a directory,
the user may not wanted to add), but didn't resurrected the original file at
deinstall time.

In this case it isn't necessary to touch the file if the directory is
included in the file at installation time of the linux_base port.

Adding the entry to the file in the linux_base port was easy and solved 2
problems (adding and removing the entry to/from the file). It would have
been possible to write code which does it correctly, but you have to
consider all possible cases. This wouldn't have been as easy as the current
solution, and you don't have to fear to have missed a case. It also solved
an "distraction" (the warning of a changed file on upgrade).

Summary: doing it the way it is is better than to do it the way it was
before.

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
Are we THERE yet?  My MIND is a SUBMARINE!!





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060111165307.lz00xrvhw8w8okok>