Date: Sun, 24 Feb 2008 23:58:30 +0100 From: Tomas Olsson <tol@stacken.kth.se> To: Alec Kloss <alec-keyword-arla.4d43de@SetFilePointer.com> Cc: afs@FreeBSD.org, Robert Watson <rwatson@FreeBSD.org>, arla-drinkers@stacken.kth.se Subject: Re: Patches to get Arla running on FreeBSD 8-CURRENT Message-ID: <1203893910.4068.14.camel@hippo.t.nxs.se> In-Reply-To: <1203788012.4065.10.camel@hippo.t.nxs.se> References: <20080216035658.W93919@fledge.watson.org> <1203286882.16414.3.camel@heterodyne.kaj> <20080218012608.V96329@fledge.watson.org> <20080222125207.GD38141@hamlet.setfilepointer.com> <20080223092516.O23969@fledge.watson.org> <20080223102922.GF38141@hamlet.setfilepointer.com> <20080223110549.GG38141@hamlet.setfilepointer.com> <20080223161249.GH38141@hamlet.setfilepointer.com> <1203788012.4065.10.camel@hippo.t.nxs.se>
next in thread | previous in thread | raw e-mail | index | archive | help
I wrote: > On Sat, 2008-02-23 at 10:12 -0600, Alec Kloss wrote: > > All of the heavy lifting is done in the big patch at > > > > http://setfilepointer.com/pub/arla/20080223-arla.diff > [...] > > Can anyone from Arla comment on the chances for incorporating > > these patches into Arla itself? It'd be nice to have these changes > > in Arla itself prior to submitting the port to FreeBSD. > > > Chances are good. If it looks ok it goes in. > Looks mostly ok, but I do have some questions. 1) appl/fs/fs_local.h: would that break `fs nnpfsdeb all`? 2) cf/try-compile-kernel.m4: why do we need /usr/include? It sounds scary given that we may want to compile using random kernel trees. Same goes for nnpfs/freebsd/FreeBSD-Makefile. I don't know much about kernel build magic. 3) cf/bsd-vop-unlock.m4: do we need it? I don't care about older versions of FreeBSD than 6.x; traditionally we try to support latest stable OS-release plus -CURRENT but maybe that's a bit limiting. Perphaps nnpfs_vfs_unlock solves part of the problem? thanks /t
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1203893910.4068.14.camel>