Date: Mon, 18 Sep 2017 10:00:16 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Eric Joyner <erj@freebsd.org> Cc: Sepherosa Ziehau <sepherosa@gmail.com>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, Robert Watson <rwatson@freebsd.org>, Andrew Gallatin <gallatin@freebsd.org> Subject: Re: ixl(4) RSS hash type Message-ID: <CAJ-VmonFumNm2-%2B=Z-zGUWxTKF3YBhPKY7vKL_pzxV2UKVL=iA@mail.gmail.com> In-Reply-To: <CA%2Bb0zg_h2XgzyyaOQB9byzGXesgOqAAeEPswv9s%2B1PfERGR-QQ@mail.gmail.com> References: <CAMOc5czdx206oahgRPNa_VcoRTGZsamfYC_PB84SgEXnuzv0fA@mail.gmail.com> <CA%2Bb0zg_h2XgzyyaOQB9byzGXesgOqAAeEPswv9s%2B1PfERGR-QQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
hi! please do fix it. I'm way busy with life right now. :) -a On 11 September 2017 at 10:18, Eric Joyner <erj@freebsd.org> wrote: > I think that sounds right; but Adrian is the one who put the code in the > #ifdef RSS blocks in. We don't have it enabled/defined in our testing here. > > - Eric > > On Sun, Sep 10, 2017 at 8:01 PM Sepherosa Ziehau <sepherosa@gmail.com> > wrote: >> >> Hi all, >> >> I am on the way to cleanup the UDP_IPV4_EX bit. The only effective >> consumer of this undefined RSS hash type is ixl. >> >> So I took a bit close look at it, then I have several question about >> its hash type configuration: >> >> ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if >> RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 >> fragments: >> >> https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex >> >> ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag >> means "outer packet header indicates a fragment", which has nothing to >> do with the any of the IPV6_EX related bits: >> >> https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types >> >> I believe these all should be fixed. >> >> Thanks, >> sephe >> >> -- >> Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonFumNm2-%2B=Z-zGUWxTKF3YBhPKY7vKL_pzxV2UKVL=iA>