Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Dec 2015 20:08:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 199480] [patch] lang/lua52, lang/lua53: use 'arc4random()' instead of 'time()' for string hash seed
Message-ID:  <bug-199480-13-TTkCP4uLdZ@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-199480-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-199480-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199480

Vitaly Magerya <vmagerya@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155642|0                           |1
        is obsolete|                            |

--- Comment #5 from Vitaly Magerya <vmagerya@gmail.com> ---
Created attachment 164875
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D164875&action=
=3Dedit
lua-arc4random.diff

The update is that the upstream doesn't mind [1].

Also, based on their suggestions, here's a new (less intrusive)
patch.

Note that the new patch fixes what seems to be a mistake in
lang/lua53/files/patch-src__Makefile: currently that file changes
"CFLAGS=3D ..." into "CFLAGS?=3D ...", which makes it so that the
"..." part is ignored, and the "MYCFLAGS" variable defined from
lang/lua53/Makefile is never used. Note that the equivalent patch
for lua52 (lang/lua53/files/patch-src__Makefile) does not add
the "?", which is the correct way to do things.

[1] http://article.gmane.org/gmane.comp.lang.lua.general/120118

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199480-13-TTkCP4uLdZ>