Date: Sun, 10 Nov 2019 16:08:19 +0000 From: Edward Tomasz Napierala <trasz@freebsd.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354458 - head/libexec/rc/rc.d Message-ID: <20191110160819.GA1095@brick> In-Reply-To: <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net> References: <201911071815.xA7IFOhI070066@repo.freebsd.org> <20191109204958.Horde.B0ynnS_aur1OZimnDNObsAt@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1109T2049, Alexander Leidinger wrote: > Quoting Edward Tomasz Napierala <trasz@freebsd.org> (from Thu, 7 Nov > 2019 18:15:24 +0000 (UTC)): > > > Author: trasz > > Date: Thu Nov 7 18:15:24 2019 > > New Revision: 354458 > > URL: https://svnweb.freebsd.org/changeset/base/354458 > > > > Log: > > Extend the linux rc script to mount the neccessary file systems, > > set ELF fallback brand, and load pty(4). > > We never did something like that. We have it documented everywhere > that it needs to be done manually. So this is at least a POLA > violation. It is great that the nocover option is used in the mount, > but it's still some kind of layering violation (I may want to have > only a subset mounted, or nothing at all). It is kind of a POLA violation, but previously the linux_enable knob didn't do much apart from loading the linux{,64}.ko kernel module and doing something weird with ldconfig, which I'm not even sure is actually useful. In other words, the old behaviour can be restored by just not using linux_enable, and instead loading the kernel modules the same way all the others are loaded. Could you give me some use case why someone would want only a subset of the filesystems? > I do not object to the functionality, but I think it needs to be > configurable (an option to influence if the auto-mount is done or not, > doesn't matter to me what the default behavior is, as long as it is > configurable) and documented (UPDATING, handbook, man-pages, maybe > even the release notes). Man page updates are pending review at https://reviews.freebsd.org/D22277. Good point about the Handbook and release notes; I'll take a look.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191110160819.GA1095>