Date: Tue, 27 Jan 2015 11:50:27 -0800 From: hiren panchasara <hiren@strugglingcoder.info> To: Sreekanth Rupavatharam <rupavath@juniper.net> Cc: "jfv@freebsd.org" <jfv@freebsd.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: Double cleanup in igb_attach Message-ID: <20150127195027.GB63990@strugglingcoder.info> In-Reply-To: <D0ED284D.1A867%rupavath@juniper.net> References: <D0EC151C.1A7B1%rupavath@juniper.net> <20150127192814.GA63990@strugglingcoder.info> <D0ED284D.1A867%rupavath@juniper.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 27, 2015 at 07:36:17PM +0000, Sreekanth Rupavatharam wrote: > > > >Seems reasonable to me at the first glance. > > > >We need to call IGB_CORE_LOCK_DESTROY(adapter) before returning though. > > > Not necessary. igb_detach does that. Bah, I read that call inside detach as UNLOCK. Yeah, you are right.=20 cheers, Hiren --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJUx+wCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lrFQIAKY7yW//68Wa3mw7vp4nH4p9 BqtJEe57mOnCC5jwC1U4V+y8Mpivc/ZG1VwJ7uvmVVK5IjLwp8xWqgh4ub8/vXpb qTQe99g3j/1kNjNuklGtuaB2sWTZ0qYTnQA8I645Ns2CrTMEuJ6B1r5JnKNYAlEE 8J/f8gfraCjtKFT/1CXedxiXodvNHcvv4s/4D6xJiPuYMFFz0wIN63McVGJK0027 bA35fkIm9TuCgpFZaIpPAe48R7VVni3mnWGnw5SGBwp6G3JQQLb8ZxnB4VjjLk3Q jvjJLdVc3+e1CWSCV4XauqQsbmTCbRbym9INB4KhvbFIVYoL+GyFAJtBriYObtw= =065L -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150127195027.GB63990>