Date: Sat, 7 Apr 2007 18:04:01 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ache@FreeBSD.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070407160401.GI63916@garage.freebsd.pl> In-Reply-To: <20070406115326.A43678@delplex.bde.org> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gJNQRAHI5jiYqw2y Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2007 at 11:58:55AM +1000, Bruce Evans wrote: > On Thu, 5 Apr 2007, Pawel Jakub Dawidek wrote: >=20 > >pjd 2007-04-05 21:10:54 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc/sys lseek.2 pathconf.2 > > sys/kern vfs_syscalls.c > > sys/sys filio.h unistd.h > > Log: > > Implement SEEK_DATA and SEEK_HOLE extensions to lseek(2) as found in > > OpenSolaris. For more information please refer to: > > > > http://blogs.sun.com/bonwick/entry/seek_hole_and_seek_data >=20 > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > support them, and the hack of declaring lseek() in stdio.h should not > be extended to new interfaces. If stdio ever supports them, then they > would need to be declared under a visibility ifdef (not #ifdef self). Ok, I removed SEEK_DATA/SEEK_HOLE from stdio.h and hidden them in sys/unistd.h under: #if !defined(_POSIX_SOURCE) && !defined(_XOPEN_SOURCE) [...] #endif This is consistent which what Solaris has. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gJNQRAHI5jiYqw2y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGF8DxForvXbEpPzQRAgNJAKCC8tbS0iOanGYrWi9jqLD75QPmSQCgh2QP yCkP/Hj79TTBWEijnx59XTI= =gN26 -----END PGP SIGNATURE----- --gJNQRAHI5jiYqw2y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070407160401.GI63916>