Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Apr 2013 22:33:59 GMT
From:      john marino <draco@marino.st>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/177660: news/noffle: [PATCH] Fix three unterminated strings in makefile
Message-ID:  <201304052233.r35MXxx7019773@red.freebsd.org>
Resent-Message-ID: <201304052330.r35NU1Vo010219@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         177660
>Category:       ports
>Synopsis:       news/noffle: [PATCH] Fix three unterminated strings in makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 05 23:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     john marino
>Release:        
>Organization:
>Environment:
>Description:
The news/noffle Makefile has three unterminated strings fed to echo commands.  bmake doesn't like it, it breaks installation.  Patch attached.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2013-04-05 22:02:52.210286000 +0000
+++ Makefile
@@ -46,12 +46,12 @@ do-install:
 		${PREFIX}/man/man5
 	${INSTALL_DATA} ${WRKSRC}/noffle.conf.example \
 		${PREFIX}/etc/noffle.conf.sample
-	@${ECHO} "
+	@${ECHO}
 	@${ECHO} "------------------------------------------------------------"
 	@${ECHO} "Sample of configuration file placed at"
 	@${ECHO} "${PREFIX}/etc/noffle.conf.sample"
-	@${ECHO} "------------------------------------------------------------
-	@${ECHO} "
+	@${ECHO} "------------------------------------------------------------"
+	@${ECHO}
 	@${MKDIR} ${SPOOL_DIR}
 	@${MKDIR} ${SPOOL_DIR}/data
 	@${MKDIR} ${SPOOL_DIR}/lock


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304052233.r35MXxx7019773>