Date: Sun, 19 Jun 2005 15:27:57 -0700 (PDT) From: Doug White <dwhite@gumbysoft.com> To: David O'Brien <obrien@freebsd.org> Cc: freebsd-current@freebsd.org, Ed Maste <emaste@phaedrus.sandvine.ca> Subject: Re: savecore(8) increments /var/crash/bounds on each boot Message-ID: <20050619152736.U83634@carver.gumbysoft.com> In-Reply-To: <20050617083507.GA3061@dragon.NUXI.org> References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> <20050614235132.L76669@mp2.macomnet.net> <20050615023600.GA20721@dragon.NUXI.org> <20050615141447.GD95217@sandvine.com> <20050617083507.GA3061@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 17 Jun 2005, David O'Brien wrote: > On Wed, Jun 15, 2005 at 10:14:47AM -0400, Ed Maste wrote: > > On Tue, Jun 14, 2005 at 07:36:00PM -0700, David O'Brien wrote: > > > Do you understand the fix? How does lying in printheader() fix anything? > > > Moving the call to getbounds() back to the original location is the "fix" > > > but then it negates -vv. We shouldn't lie in printheader(). > > > > Fair enough, on dwhite's suggestion here's another try that splits the > > increment-and-write out from getbounds() so that the bounds value can > > be shown with -vv. > ..snip.. > > --- savecore.c.orig 2005-06-13 16:19:41.000000000 -0400 > > +++ savecore.c 2005-06-15 09:41:52.000000000 -0400 > ... > > + writebounds(bounds+1); > ^^^^^^^^ > bounds + 1 > > I like the patch, after the style(9) fix. Might as well avoid a > brucification. ;-) Who's going to commit this patch? I'll get this committed. -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050619152736.U83634>